-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization merge suggestion improvements #1649
Merged
epipav
merged 10 commits into
main
from
improvement/organization-merge-suggestions-scripts
Oct 10, 2023
Merged
Organization merge suggestion improvements #1649
epipav
merged 10 commits into
main
from
improvement/organization-merge-suggestions-scripts
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com:CrowdDotDev/crowd.dev into improvement/organization-merge-suggestions-scripts
sausage-todd
reviewed
Oct 9, 2023
themarolt
reviewed
Oct 10, 2023
…nvenience script does the actual processing
…ng in merge suggestion worker
themarolt
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dge case fixes
Changes proposed ✍️
What
🤖 Generated by Copilot at 280a61c
This pull request improves the performance and accuracy of the
getMergeSuggestions
method for finding duplicate identities in organizations. It also adds more logging information to thegenerateMergeSuggestions
method for debugging purposes. The changes affect the filesorganizationRepository.ts
andorganizationService.ts
in the backend.
🤖 Generated by Copilot at 280a61c
Why
How
🤖 Generated by Copilot at 280a61c
prefixLength
toOrganizationRepository
to calculate the optimal prefix length for a given string (link)getMergeSuggestions
to sort and collapse by uuid and avoid duplicates (link)getMergeSuggestions
to use the last uuid as a filter and avoid missing or repeating results (link, link)prefixLength
function call for the prefix search (link)generateMergeSuggestions
inOrganizationService
to log the tenant id (link)hasSuggestions
togenerateMergeSuggestions
to keep track of whether the tenant has any suggestions or not (link)generateMergeSuggestions
to log different messages based on the value ofmergeSuggestions
andhasSuggestions
(link)Checklist ✅
Feature
,Improvement
, orBug
.