fixes and improvements for transaction handling in member and org merge #1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 1d24700
This pull request refactors the transaction handling in several database repository classes and service classes. It simplifies the code by passing the transaction object as part of the options parameter and using a helper method to create consistent repository options. It also improves the error handling and logging of some methods and fixes some minor code style and formatting issues.
🤖 Generated by Copilot at 1d24700
Why
How
🤖 Generated by Copilot at 1d24700
createTransactionalRepositoryOptions
inSequelizeRepository
to simplify transaction creation and return a repository options instance with the transaction included (link)createTransaction
method inSequelizeRepository
for better type checking and documentation (link)MemberRepository
andOrganizationRepository
prefixes to some static method calls for consistency and clarity (link, link)OrganizationService
for code formatting, readability, and consistency (link, link, link)triggerMemberSync
,triggerRemoveMember
, andtriggerOrganizationSync
to improve error handling and logging inMemberService
andOrganizationService
(link, link, link)MemberService
andOrganizationService
to prevent errors if the transaction was not created successfully (link, link)merge
method inMemberService
for code formatting and readability (link, link)Checklist ✅
Feature
,Improvement
, orBug
.Add screehshots to the PR description for relevant FE changesNew backend functionality has been unit-tested.API documentation has been updated (if necessary) (see docs on API documentation).