Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination and total_count improvements in organization merge suggestions #1701

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Oct 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 0eb3fc6

Rewrote and improved the SQL query to fetch the organizations to merge in organizationRepository.ts. The query now filters, counts, and orders the results more efficiently and correctly.

🤖 Generated by Copilot at 0eb3fc6

CTEs improve
SQL query for merging
Organizations

Why

How

🤖 Generated by Copilot at 0eb3fc6

  • Rewrite SQL query to fetch organizations to merge using CTEs, filters, count, and order by hash (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav self-assigned this Oct 16, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Oct 16, 2023
@epipav epipav marked this pull request as ready for review October 16, 2023 17:59
@epipav epipav requested a review from themarolt October 17, 2023 08:24
@epipav epipav merged commit 9bffcd3 into main Oct 17, 2023
8 checks passed
@epipav epipav deleted the bugfix/org-merge-suggestions-with-segments branch October 17, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants