Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking deletedAt when finding mutually exclusive organization members while merging #1756

Merged

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Oct 23, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3cb5b3f

Fix a bug where soft-deleted organizations could still be accessed by slug. Update the getOrganizationBySlug method in organizationRepository.ts to exclude soft-deleted records.

🤖 Generated by Copilot at 3cb5b3f

getOrganization
Filters out soft-deleted ones
Autumn leaves falling

Why

How

🤖 Generated by Copilot at 3cb5b3f

  • Implement soft deletion for organizations by adding a deleted_at column to the organizations table and a deleted scope to the Organization model (F0

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav requested a review from themarolt October 23, 2023 11:55
@epipav epipav self-assigned this Oct 23, 2023
@epipav epipav marked this pull request as ready for review October 23, 2023 11:55
@epipav epipav merged commit 4d0e629 into main Oct 23, 2023
8 checks passed
@epipav epipav deleted the bugfix/also-check-for-deletedAt-finding-mutually-exclusive-orgs branch October 23, 2023 12:49
epipav added a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants