Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Contributing guidelines #1777

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Enhanced Contributing guidelines #1777

merged 2 commits into from
Oct 30, 2023

Conversation

Arcturus22
Copy link
Contributor

@Arcturus22 Arcturus22 commented Oct 26, 2023 •
edited

Changes Proposed

What

Corrected grammar of Contributing file.

@Arcturus22
Copy link
Contributor Author

@joanagmaia @sausage-todd
Please review my PR and merge it. It is a documentation Improvement PR

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@Arcturus22
Copy link
Contributor Author

@loicsaintroch @joanagmaia @themarolt
Please review my PR and merge it. Suggest if any changes.

@Arcturus22
Copy link
Contributor Author

@loicsaintroch @joanagmaia @themarolt
Please review my PR and merge it. Suggest if any changes.

@Arcturus22 Arcturus22 closed this Oct 30, 2023
@Arcturus22 Arcturus22 reopened this Oct 30, 2023
@Arcturus22
Copy link
Contributor Author

@loicsaintroch @joanagmaia @themarolt
Please review the PR. I have resolved the conflicts.

@joanagmaia
Copy link
Contributor

joanagmaia commented Oct 30, 2023 •
edited

Hey @Arcturus22!
Thanks for your interest in contributing! I don't see any file changes. Do you have everything committed and pushed?

Screenshot 2023-10-30 at 12 46 31

@Arcturus22
Copy link
Contributor Author

@joanagmaia
I'm sorry, but it wasn't updated/pushed. I have pushed the changes now. Please review and merge it.
Suggest if any changes.

joanagmaia
joanagmaia approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joanagmaia joanagmaia merged commit 87af5e6 into CrowdDotDev:main Oct 30, 2023
4 checks passed
sausage-todd pushed a commit that referenced this pull request Nov 9, 2023
@Arcturus22 @sausage-todd
Enhanced Contributing guidelines (#1777)
f5fa8c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arcturus22 @CLAassistant @joanagmaia