Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch synchronous API #1811

Merged
merged 44 commits into from
Nov 7, 2023
Merged

Opensearch synchronous API #1811

merged 44 commits into from
Nov 7, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 3, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ad1640c

This pull request introduces the search-sync-api service, which replaces the search-sync-worker emitter for synchronizing the search index with the database. It adds new workflows, configuration, and scripts for building and deploying the service, and updates the existing services to use the new client. It also simplifies the code and removes unnecessary dependencies and parameters.

🤖 Generated by Copilot at ad1640c

We're breaking free from the search-sync-worker
We're using the search-sync-api to unleash the power
We're simplifying the code and removing the waste
We're synchronizing the search with the database

Why

How

🤖 Generated by Copilot at ad1640c

  • Add a new utility function to get the search-sync-api client instance, using the configuration from the conf module (link)
  • Replace the search-sync-worker emitter with the search-sync-api client in various service files, and remove the tenant id parameter from the trigger methods (link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link,link)
  • Add a new property to the default and custom environment variables files that holds the search-sync-api configuration object (link,link)
  • Add a new environment variable to the composed, local and test configuration files that specifies the base URL of the search-sync-api service (link,link,link)
  • Add a new import statement to the conf index file that imports the search-sync-api configuration interface from the opensearch library, and a new constant that gets the search-sync-api configuration object from the config module (link,link)
  • Add a new workflow file that triggers the build and deploy of the search-sync-api service to the LF staging cluster, when there are changes in the relevant paths on the lf-staging branches (link)
  • Add a new workflow file that triggers the build and deploy of the search-sync-api service to the staging cluster, when there are changes in the relevant paths on the staging branches (link)
  • Add a new input parameter to the production and LF production workflows that allows the user to choose whether to deploy the search-sync-api service or not (link,link)
  • Add a new job to the production and LF production workflows that builds and pushes the docker image for the search-sync-api service, if the input parameter is true (link,link)
  • Add a new job to the production and LF production workflows that deploys the search-sync-api service to the crowd cluster, if the input parameter is true (link,link)
  • Add a new script file that defines the dockerfile, context and repository for the search-sync-api service image (link)
  • Add a new dockerfile for the search-sync-api service that copies the relevant files and installs the dependencies (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review November 3, 2023 09:42
@epipav epipav requested a review from themarolt November 7, 2023 12:44
@epipav epipav self-assigned this Nov 7, 2023
@epipav epipav added the Feature Created by Linear-GitHub Sync label Nov 7, 2023
@epipav epipav merged commit 016a862 into main Nov 7, 2023
9 checks passed
@epipav epipav deleted the feature/synchronous-opensearch-sync branch November 7, 2023 15:30
sausage-todd pushed a commit that referenced this pull request Nov 9, 2023
Co-authored-by: Yeganathan S <hilariousengineer@protonmail.com>
Co-authored-by: Joana Maia <joana@crowd.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants