Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact findById activity aggregates #1818

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 6, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 15d7261

This pull request enhances the MemberRepository class with a new interface and method for aggregating member activities. It also improves the findById method by using the new aggregation feature. These changes support the backend logic for displaying member profiles and activity feeds.

🤖 Generated by Copilot at 15d7261

New interface for
MemberRepository
Spring cleaning the code

Why

How

🤖 Generated by Copilot at 15d7261

  • Define ActivityAggregates interface to represent member's activity data (link)
  • Add getActivityAggregates method to MemberRepository class to query activity aggregates from database using raw SQL (link)
  • Refactor findById method of MemberRepository class to use getActivityAggregates method and return output object with matching properties (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review November 6, 2023 11:19
@epipav epipav self-assigned this Nov 6, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Nov 6, 2023
@epipav epipav requested review from themarolt and sausage-todd and removed request for themarolt November 6, 2023 12:52
@epipav epipav merged commit 01dc552 into main Nov 6, 2023
8 checks passed
@epipav epipav deleted the bugfix/contact-findById-aggregates branch November 6, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants