-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact findById activity aggregates #1818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DotDev/crowd.dev into bugfix/contact-findById-aggregates
epipav
requested review from
themarolt and
sausage-todd
and removed request for
themarolt
November 6, 2023 12:52
sausage-todd
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 15d7261
This pull request enhances the
MemberRepository
class with a new interface and method for aggregating member activities. It also improves thefindById
method by using the new aggregation feature. These changes support the backend logic for displaying member profiles and activity feeds.
🤖 Generated by Copilot at 15d7261
Why
How
🤖 Generated by Copilot at 15d7261
ActivityAggregates
interface to represent member's activity data (link)getActivityAggregates
method toMemberRepository
class to query activity aggregates from database using raw SQL (link)findById
method ofMemberRepository
class to usegetActivityAggregates
method and return output object with matching properties (link)Checklist ✅
Feature
,Improvement
, orBug
.