Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizations missing data #1836

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Organizations missing data #1836

merged 5 commits into from
Nov 10, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 10, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 9d03004

Improved organization data update logic in organizationService.ts. Used helper functions to avoid unnecessary database operations and ensure data integrity.

🤖 Generated by Copilot at 9d03004

Oh, we are the coders of the sea
And we update the orgs with glee
We use isEqual and updateData
To change the fields that need a tweak, hooray!

Why

How

🤖 Generated by Copilot at 9d03004

  • Import isEqual function to compare objects for equality (link)
  • Modify logic for updating organization cache to only update changed fields and exclude name field (link)
  • Merge updated cache data with original cache data to reflect changes (link)
  • Modify logic for updating organization record to only update changed fields and include website field if missing (link)
  • Use updateData object to store fields that need to be updated (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review November 10, 2023 12:15
@epipav epipav self-assigned this Nov 10, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Nov 10, 2023
@epipav epipav merged commit 78041c7 into main Nov 10, 2023
8 checks passed
@epipav epipav deleted the bugfix/organizations-missing-data branch November 10, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants