Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary opensearch client initializations #1863

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 21, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at cc8a366

This pull request refactors the code in the search_sync_api service to use a common OpenSearchService instance from the request object. This reduces the number of unnecessary connections to the OpenSearch cluster and simplifies the code in the activity.ts, member.ts, and organization.ts files.

🤖[deprecated] Generated by Copilot at cc8a366

To improve the code's performance and look
The devs refactored how they used opensearch
They passed it as a property of req
Instead of making new instances, you see
And thus they reduced the code's complexity

Why

How

🤖[deprecated] Generated by Copilot at cc8a366

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav self-assigned this Nov 21, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Nov 21, 2023
@epipav epipav marked this pull request as ready for review November 21, 2023 09:51
…of github.com:CrowdDotDev/crowd.dev into improvement/remove-unnecessary-opensearch-client-init
@epipav epipav merged commit 89242fb into main Nov 21, 2023
7 of 8 checks passed
@epipav epipav deleted the improvement/remove-unnecessary-opensearch-client-init branch November 21, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants