Add global filters #425
Add global filters #425
Conversation
joanagmaia
force-pushed
the
feature/filter-widgets
branch
from
6da3390
to
f0e6e48
Compare
There was a problem hiding this comment.
Looking really good! Amazing work here @joanagmaia
Left a minor comment, and will test try to test things locally before approving 👍
| /> | ||
| </div> | ||
| </app-page-wrapper> | ||
| <!-- Custom Report --> | ||
| <div v-else class="max-w-5xl flex flex-grow mx-auto"> | ||
| <app-report-grid-layout | ||
| v-model="report" | ||
| :is-public-view="true" |
There was a problem hiding this comment.
Was this hardcoded on purpose?
There was a problem hiding this comment.
Yes, maybe the name itself is not the best but basically this boolean indicates that the report is being seen in the public view. Since this is the report-view-page-public.vue component this is always the public view
Should I update the prop name to something else?
There was a problem hiding this comment.
Makes sense!
Should I update the prop name to something else?
No need, just wanted to double-check if was intended 👍
| } | ||
|
|
||
| const onTrackFilters = () => { | ||
| window.analytics.track('Filter report', { |
There was a problem hiding this comment.
Maybe we should differentiate here that this is a template/default report (within the event name)
There was a problem hiding this comment.
Will do! Thanks for the suggestion
Changes proposed ✍️
widget-queriesto hold all template related queries logicreport-template-filterscomponent to handle the rendering and update logic of the filterScreenshots (front-end changes only)
Checklist ✅
Feature,Enhancement, orBug.frontend/.env.dist.local,frontend/.env.dist.composed.backend/.env.dist.local,backend/.env.dist.composed.