Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js_includes as a dependency for one of the bundles so users can enable it. #791

Closed
kevincrafts opened this issue Jan 5, 2021 · 3 comments · Fixed by #795
Closed
Labels
question Further information is requested

Comments

@kevincrafts
Copy link
Member

We should attach this to an existing bundle so it's easy to enable and add an update hook for that bundle so it will be enabled for sites that already have that bundle enabled.

Kevin will look through the bundles to see which one it should be part of. Since this module uses context, it should probably be part of a module that also enables the context UI.

@kevincrafts
Copy link
Member Author

I think cu_advanced_layout_bundle might be the leading candidate so far.

@cathysnider
Copy link
Contributor

cathysnider commented Jan 5, 2021

Questions brought up by Emily:

  • Are they moving the digital campaign embeds to work with includes or will those still be separate?
  • Slate forms is part of includes but it also has it's own bundle so will they remove that slate bundle?
  • What is the process to enable the LiveChat feature
  • Should I create a new form for people to fill out?

@kevincrafts
Copy link
Member Author

  1. Some parts of the digital campaign bundle should be removed at some point. This includes the Slate bundle but all of those will need to be migrated. The embeds/tracking pixels are handled by GoogleTagManager so I think the only thing left might be the funnel pages, which could also be moved into another bundle.

  2. The Livechat, and any other functionality that is part of the js includes module will be automatically enabled for any site that enables its parent bundle. There will be no need for a request form.

@jwfuller jwfuller added the question Further information is requested label Jan 12, 2021
@jwfuller jwfuller linked a pull request Jan 12, 2021 that will close this issue
@jwfuller jwfuller linked a pull request Jan 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants