Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if pose pipeline can see tags and error if not #18

Open
spacey-sooty opened this issue May 25, 2024 · 2 comments · May be fixed by #14
Open

Check if pose pipeline can see tags and error if not #18

spacey-sooty opened this issue May 25, 2024 · 2 comments · May be fixed by #14
Assignees
@spacey-sooty
Labels
enhancement New feature or request

Comments

@spacey-sooty
Copy link
Member

This can allow us to skip pose filtering if there's no tags in view (pose has to be wrong in this case).
@spacey-sooty spacey-sooty added the enhancement New feature or request label May 25, 2024
@spacey-sooty
Copy link
Member Author

Limelight makes this quite difficult from what I can tell, but its a simple change with PhotonVision

@spacey-sooty
Copy link
Member Author

the limelight api is terribly documented, its the 7th entry in the botpose https://github.com/LimelightVision/limelightlib-wpijava/blob/main/LimelightHelpers.java#L511

spacey-sooty added a commit that referenced this issue Jun 26, 2024
@spacey-sooty
Don't pass odometry if less than two tags are detected
71f75e1 
Resolves #18
spacey-sooty added a commit that referenced this issue Jun 26, 2024
@spacey-sooty
Ignore vision measurements if less than two tags are detected
d70ac8d 
Resolves #18
@spacey-sooty spacey-sooty linked a pull request Jun 26, 2024 that will close this issue
[swerve] pass vision measurements to odometry #14
Open
spacey-sooty added a commit that referenced this issue Jun 26, 2024
@spacey-sooty
Ignore vision measurements if less than two tags are detected
0e9aa0f 
Resolves #18
spacey-sooty added a commit that referenced this issue Jul 3, 2024
@spacey-sooty
Ignore vision measurements if less than two tags are detected
ada0c7d 
Resolves #18
spacey-sooty added a commit that referenced this issue Jul 3, 2024
@spacey-sooty
Ignore vision measurements if less than two tags are detected
49aa697 
Resolves #18
@spacey-sooty spacey-sooty self-assigned this Jul 3, 2024
spacey-sooty added a commit that referenced this issue Jul 4, 2024
@spacey-sooty
Ignore vision measurements if less than two tags are detected
02c670e 
Resolves #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacey-sooty spacey-sooty

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[swerve] pass vision measurements to odometry CurtinFRC/2024-Offseason
1 participant
@spacey-sooty