This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Code review

Jump to bottom

raphik12 edited this page Apr 2, 2013 · 2 revisions

Code Review

The goal of the code review is to:

Insure the quality of the submission
Inform others of changes to the project

Code reviewers should check the following things:

All current regression tests pass
Regression tests have been updated:
- New features require new tests
- Changed features require changed tests
- Bug fixes should have tests that will find the bug if it sneaks back
Syntax is harmonious with the rest of the file, if not the rest of the project
- Syntax should roughly match standard style guides for the language in question, such as the Coffeescript Style Guide and the Javascript Style Guide
- Consistency is more important than strict adhesion to the rules