Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin: Support additional build info in binaries built with Go 1.18+ #86

Closed
nscuro opened this issue Oct 17, 2021 · 3 comments
Closed

bin: Support additional build info in binaries built with Go 1.18+ #86

nscuro opened this issue Oct 17, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@nscuro
Copy link
Member

nscuro commented Oct 17, 2021

See golang/go#37475
@nscuro nscuro added the enhancement New feature or request label Oct 17, 2021
@nscuro nscuro added this to the v1.1.0 milestone Nov 10, 2021
@nscuro
Copy link
Member Author

nscuro commented Nov 18, 2021

Go 1.18 introduces an API to extract BuildInfo from binaries without having to have go present on the system: https://github.com/golang/go/blob/85a068fdf21bd2e4475a87ee049af4fbe797bcbe/src/debug/buildinfo/buildinfo.go#L73

@nscuro
Copy link
Member Author

nscuro commented Nov 20, 2021

There are some subtle changes to Go's output here: https://go-review.googlesource.com/c/go/+/358539/

@nscuro nscuro mentioned this issue Dec 3, 2021
Merged
@nscuro
Copy link
Member Author

nscuro commented Dec 3, 2021

Done with #101

@nscuro nscuro closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@nscuro