Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code generating resolved PURLs, fixes performance issue #311 #345

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

knrc
Copy link
Contributor

@knrc knrc commented Apr 21, 2023

No description provided.

@knrc knrc changed the title Remove code generating resolved PURLs, fixes #311 WIP: Remove code generating resolved PURLs, fixes #311 Apr 22, 2023
@hboutemy
Copy link
Contributor

nice job
anything required before merging?
do you need help?

@hboutemy hboutemy added the bug label Apr 24, 2023
@hboutemy hboutemy changed the title WIP: Remove code generating resolved PURLs, fixes #311 WIP: Remove code generating resolved PURLs, fixes performance issue #311 Apr 24, 2023
@knrc
Copy link
Contributor Author

knrc commented Apr 24, 2023

@hboutemy Yes, I have one thing more to handle before this is good to go. Will update the PR shortly

@knrc
Copy link
Contributor Author

knrc commented Apr 25, 2023

@hboutemy this should be good to go now, I addressed the last part and added a test to cover it

Signed-off-by: Kevin Conner <kev.conner@gmail.com>
@hboutemy hboutemy changed the title WIP: Remove code generating resolved PURLs, fixes performance issue #311 Remove code generating resolved PURLs, fixes performance issue #311 Apr 25, 2023
@hboutemy hboutemy merged commit 5aa50ac into CycloneDX:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants