Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpregistries subcommand is not guarded by a permission #180

Closed
andriihorpenko opened this issue May 6, 2024 · 1 comment
Closed

dumpregistries subcommand is not guarded by a permission #180

andriihorpenko opened this issue May 6, 2024 · 1 comment

Comments

@andriihorpenko
Copy link

Issue type:

  • 🐛 Bug

Short description:

The dumpregistries subcommand has no permission requirement set, giving anyone an ability to execute this command. Even though this is not a vulnerability, this may cause unnecessary load on a server when used dozens of times by bad actors.

Steps to reproduce the problem:

  1. Be a player with no advanced permissions granted
  2. Use /cyclopscore dumpregistries

Expected behaviour:

Guard a command with an OP check or permission level >= 2, like vanilla does in dozens of commands.


Versions:

  • This mod: 1.19.1
  • Minecraft: 1.19.2
  • Forge: 43.3.13

Log file:

No log file required

@rubensworks
Copy link
Member

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants