warning Two or more files with the name of reply.cpp

[MikesAracade]

I'm working on a Windows build of your library.
The changes to support WIN32 were not bad at all.

However, I'm having this issue:

_warning MSB8027: Two or more files with the name of reply.cpp will produce outputs to the same location. This can lead to an incorrect build result. The files involved are sources\replies\reply.cpp, sources\reply.cpp._

It looks like the 'reply' class exists in both files.
However the top one contains these extra methods:

array_reply& as_array(void);
bulk_string_reply& as_bulk_string(void);
error_reply& as_error(void);
integer_reply& as_integer(void);
simple_string_reply& as_simple_string(void);

The test project needs the extra methods.
Can we unify these so there is only one reply hpp and cpp?
Run a compare tool on the two files so you can see the difference.

Thanks,
Mike M.

P.S Awesome work! I'm almost ready to run the tests...

[Cylix]

Hi,

Thanks for your interest in cpp_redis and for porting the library to Windows! Good job!

Indeed, the reply part is something I have coded a long time ago and by looking again at the implementation this morning, I was really not satisfied with it.

So, I just cleaned this and kept only a single reply.(hpp|cpp) file (the whole replies folder has been removed).

Concerning the tests, I added a bunch of integration tests yesterday as well as configuring Travis. However, I'm still working on a convenient way to run the async integration tests: so don't worry if you see some redis_client/redis_subscriber related tests failing sometimes but succeeding on other runs.. Though all other tests (builders/replies tests) should all pass as they are unit tests.

Thanks