This repository has been archived by the owner on Apr 6, 2019. It is now read-only.
refactor the reply classes to keep only one simplified class. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cylix
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #11, the current implementation of the
replyis not really clean and could be simplified.This PR aims to simplify the
replyimplementation by keeping only a singlereply.(cpp|hpp)file with a cleaner and simpler implementation (remove the more complex and unnecessary architecture based on inheritance / dynamic_casts / ...).Apply the changes to internal builder classes.
Public API
replyAPI is unchanged, so no client code has to be modified after these changes.