-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some bathymetry grid sizes are not immediately friendly to XBGPU #34
Comments
Hi @CyprienBosserelle , I don't want to pressure you on this issue at all, just wondering what your projected time to address this issue might be? It affects whether we assume it will be done in the next 6mo, say, or we add warnings into our conversion code when the input grids might not work with XB-GPU. |
I definitely want to fix that issue and there are two ways of dealing with this.
XBGPU does need a bit of attention but I'm flat out for the next 4-6 month so I don't think I can do the second option any time soon. If extending grids as part of the conversion is not acceptable I can try to squeeze option 1. |
We may yet be able to provide an intermediate workaround by including the ability to modify the bathymetry file via the conversion script if necessary. |
A somewhat related issue is the apparent need to double up the last rows and columns in the bathy file, at least in some scenarios. |
We have found it necessary to sometimes change the bathymetry grid in order for XGBPU to not yield unexpected results, e.g. by cutting the first row and column.
It would be good for XBGPU to be able to detect and correct for this automatically.
The text was updated successfully, but these errors were encountered: