UniTask fails to compile when Physics or Physics2D module is disabled

[Razenpok]

As per title, you can disable built-in Unity modules which causes errors during compilation.

[RamType0]

I made PR which will fix this, but this issue also present for many other packages(Include unity official packages).
So you will continue to have headache for this issue even if it merged.

[neuecc]

I disagree with adding it to dependencies.

[Razenpok]

I agree with @neuecc

Probably conditional defines would be better
https://docs.unity3d.com/2020.1/Documentation/Manual/ScriptCompilationAssemblyDefinitionFiles.html#define-symbols

[Razenpok]

Smth like this

[RamType0]

I agree with @neuecc

Probably conditional defines would be better
https://docs.unity3d.com/2020.1/Documentation/Manual/ScriptCompilationAssemblyDefinitionFiles.html#define-symbols

Note that conditional defines doesn't work in Unity 2018.4.

So it will be breaking changes for Unity2018.4 users.

Package dependencies are supported in Unity 2018.4, so I used it, which makes no breaking changes for Unity 2018.4 users.

Also, I previously tried to solve this kind of issue with conditional defines in #126, but it was not merged.

I have not heard clear answer yet(I just heard that not desirable or disagree).

[Razenpok]

This feature can be applied starting from Unity 2019.1

#if !UNITY_2019_1_OR_NEWER || UNITASK_PHYSICS_2D

This shouldn't be a big deal since Unity 2018.4 will be out of support very soon

https://unity3d.com/unity/qa/lts-releases

Unity 2018.4 is now the legacy LTS; it will be updated monthly until it reaches the end of its support cycle in spring 2021.

[RamType0]

This shouldn't be a big deal since Unity 2018.4 will be out of support very soon

https://unity3d.com/unity/qa/lts-releases

Unity 2018.4 is now the legacy LTS; it will be updated monthly until it reaches the end of its support cycle in spring 2021.

Personally, I agree with it.(So I made #126)

I am ready to make PR with conditional define , but I'm really not sure about what @neuecc disagree and what will he agree.

[neuecc]

@Razenpok
Already UniTask defines com.unity.modules.assetbundle -> UNITASK_ASSETBUNDLE_SUPPORT so I'll define same way for physics.
I've released 2.1.2, it defined for Physics, Physics2D, ParticleSystem, uGUI, WebRequest.

[neuecc]

@RamType0
#126 is completely different.
It separates dependency, to asmdef.
If you think they are the same thing, then you have a mind problem.
Unfortunately, I'm going to block you from this repository for a while.

[Razenpok]

Thanks!