Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rotations #43

Closed
lstagner opened this issue Feb 20, 2015 · 2 comments
Closed

Refactor rotations #43

lstagner opened this issue Feb 20, 2015 · 2 comments

Comments

@lstagner
Copy link
Member

FIDASIM and prefida use the wrong convention for rotations with angles defined to the negative x axis. There is also some device specific routines in fidasim.f90 that relate to rotations. I suggest the following.

  1. Right handed coordinate system for beam
  2. +x direction should be defined as into the plasma
  3. Positive angle == counter-clockwise rotation
  4. When going from beam coor. to mach. coor. first rotate about z axis and then about y axis.
  5. Replace current rotation matrices with one rotation matrix R = Ry*Rz

Also tilted beam is broken
@lstagner lstagner mentioned this issue Mar 5, 2015
Closed
16 tasks
@lstagner
Copy link
Member Author

lstagner commented Mar 7, 2015

Here is how rotations should be implemented. http://nbviewer.ipython.org/gist/lstagner/e883a2b7b769f2fc46b5

lstagner pushed a commit that referenced this issue Mar 10, 2015
Beam grid rotations are now fixed (Closes #43).
a90811b 
Rewrite track in fidasim.f90 to account for fact beam grid is defined by center of cells
Moved around subroutines to put into a sensible order
@lstagner
Copy link
Member Author

Fixed in a90811b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lstagner