Fix error response/AdminITlicense tests #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime errors returned from a bean trigger a transaction rollback exception and either those exceptions have to be caught (i.e. as in https://github.com/IQSS/dataverse/blob/e7be5947abf2fbaa9ceaac09b27a60d439647f24/src/main/java/edu/harvard/iq/dataverse/search/SearchServiceBean.java#L354-L357) or some non-runtime exception has to be returned. I used the WrappedResponse class as a way to simplify but reviewers may have some other preference (e.g. just catch the transaction exceptions as in the SearchServiceBean or use non-runtime exceptions directly in the LicenseServiceBean class). Any of these should assure a non-null response is returned which in turn should allow the AdminIt tests to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The build for the PR to IQSS shows a test failing. This commit should fix it. See the commit comment for details.