Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoModules naming problem #166

Closed
im-kulikov opened this issue Mar 6, 2019 · 4 comments
Closed

GoModules naming problem #166

im-kulikov opened this issue Mar 6, 2019 · 4 comments

Comments

@im-kulikov
Copy link

→ go get -u gopkg.in/DATA-DOG/go-sqlmock.v1
go: gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.2: go.mod has non-....v1 module path "github.com/DATA-DOG/go-sqlmock" at revision v1.3.2
go: error loading module requirements

Problem with module naming here from commit

module github.com/DATA-DOG/go-sqlmock

In documentation:

go get gopkg.in/DATA-DOG/go-sqlmock.v1
@l3pp4rd
Copy link
Member

l3pp4rd commented Mar 6, 2019

Hi, yes this was misleading, since the tag was created before renaming. Just recently made another tag v1.3.3 in order to prevent these misunderstandings in the future, caused by migration to module.

@im-kulikov
Copy link
Author

Thanks..

@jeffreylo
Copy link

jeffreylo commented Apr 12, 2019

I think this is still an issue:

λ go get -u gopkg.in/DATA-DOG/go-sqlmock.v1
go: gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.3: go.mod has non-....v1 module path "github.com/DATA-DOG/go-sqlmock" at revision v1.3.3
go get: error loading module requirements

Should go.mod record the fully qualified module name, i.e., gopkg.in/DATA-DOG/go-sqlmock.v1?

@l3pp4rd
Copy link
Member

l3pp4rd commented Apr 13, 2019

Hi @jeffreylo we cannot rely making module name as gopkg.in, that service may just go away any time. Use github.com/DATA-DOG/go-sqmock for go get and anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants