Use generation options for temporal formatting #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonOellerer
force-pushed
the
fix/format_temporal_with_options
branch
from
55cdda0
to
5d9d40c
Compare
Up until now, the generation options were only applied to temporal objects in certain cases. This commit uses the options as second source of value if a temporal field is not annotated with the `@Format` annotation.
AntonOellerer
force-pushed
the
fix/format_temporal_with_options
branch
from
5d9d40c
to
6c59c0c
Compare
This was referenced Oct 4, 2022
alexpartsch
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the generation options were only
applied to temporal objects in certain cases.
This commit uses the options as second source
of value if a temporal field is not annotated with the
@Formatannotation.