Allow using @Translatable on objects #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonOellerer
force-pushed
the
fix/translatable_on_objects
branch
from
fa935b4
to
d0651c5
Compare
Up until now, the `@Translatable` annotation only worked on Strings and Enums. To be able to also specify more complex objects as translatable, the annotation is extended by an optional `toStringMethod` which is used to retrieve a string value to translate for those objects.
AntonOellerer
force-pushed
the
fix/translatable_on_objects
branch
from
d0651c5
to
3e16d3e
Compare
alexpartsch
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the
@Translatableannotationonly worked on Strings and Enums.
To be able to also specify more complex objects as
translatable, the annotation is extended by an
optional
toStringMethodwhich is used to retrievea string value to translate for those objects.
Merge after #170