Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation of CLI arguments #45

Open
johannesmoos opened this issue Jul 4, 2021 · 2 comments
Open

Input validation of CLI arguments #45

johannesmoos opened this issue Jul 4, 2021 · 2 comments

Comments

@johannesmoos
Copy link

Input validation of CLI arguments would be a valuable feature to immediately notice that a given CLI command is not valid (instead of waiting for the parser to do its thing and then wondering why there are no results :)

Currently all of the following get accepted:

pbgpp.py --pcap test.pcap --filter-message-type=TEST
pbgpp.py --pcap test.pcap --filter-message-subtype=TEST
pbgpp.py --pcap test.pcap --filter-next-hop=TEST
pbgpp.py --pcap test.pcap --filter-source-ip=TEST

I didn't test all of the arguments, but I guess it's not implemented at all currently.

@thannaske
Copy link
Contributor

Hey JMo! You are guessing right. At the moment there is no input validation regarding the command line arguments, except for those that are restricted to a list of well defined values (e.g. the message types).

@johannesmoos
Copy link
Author

Hi Tobias,

but then

pbgpp.py --pcap test.pcap --filter-message-type=TEST
pbgpp.py --pcap test.pcap --filter-message-subtype=TEST

should throw an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants