This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Fix links in the header of the MNO requests table #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently switched out the implementation of `govuk_link_to`, from the one that was defined in the app, to a version that is defined in the `govuk-components` gem. This meant that the MNO requests table links weren't being generated quite correctly and weren't getting the 'govuk-link' class applied to them. This change hardcodes the path helper to the MNO request index path, so I've changed the helper name to reflect that.
fofr
approved these changes
Oct 6, 2020
|
Is this another example of |
Yep, raised an issue with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We recently switched out the implementation of
govuk_link_to, fromthe one that was defined in the app, to a version that is defined in the
govuk-componentsgem.This meant that the MNO requests table links weren't being generated quite correctly
and weren't getting the 'govuk-link' class applied to them.
Changes proposed in this pull request
This change hardcodes the path helper to the MNO request index path, so
I've changed the helper name to reflect that.