Ensure that command-prompt is dismissed after a command creates a new screen #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… screen Fixes DFHack#1803 Running a command that created a new screen would previously result in a screen order that looked like this, due to how `Screen::Hide` works: - DF screen - `command-prompt` screen (dismissed) - New screen The `command-prompt` screen remained on the stack until the new screen was dismissed, so it would intercept viewscreen vmethod calls intended for the DF screen. This change adds a new behavior to `Screen::Hide` that results in this screen order after running a command: - DF screen - New screen - `command-prompt` screen (dismissed) - DF removes this screen immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1803
Running a command that created a new screen would previously result in a screen order that looked like this, due to how
Screen::Hideworks:command-promptscreen (dismissed)The
command-promptscreen remained on the stack until the new screen was dismissed, so it would intercept viewscreen vmethod calls intended for the DF screen.This change adds a new behavior to
Screen::Hidethat results in this screen order after running a command:command-promptscreen (dismissed) - DF removes this screen immediately