Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that command-prompt is dismissed after a command creates a new screen #1804

Merged
merged 1 commit into from Apr 3, 2021

Commits on Mar 22, 2021

  1. Ensure that command-prompt is dismissed after a command creates a new…

    … screen
    
    Fixes DFHack#1803
    
    Running a command that created a new screen would previously result in a screen
    order that looked like this, due to how `Screen::Hide` works:
    
    - DF screen
      - `command-prompt` screen (dismissed)
        - New screen
    
    The `command-prompt` screen remained on the stack until the new screen was
    dismissed, so it would intercept viewscreen vmethod calls intended for the
    DF screen.
    
    This change adds a new behavior to `Screen::Hide` that results in this screen
    order after running a command:
    
    - DF screen
      - New screen
        - `command-prompt` screen (dismissed) - DF removes this screen immediately
    lethosor committed Mar 22, 2021
    Copy the full SHA
    59b023c View commit details
    Browse the repository at this point in the history