Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exportlegends and logregion #236

Merged

Conversation

PeridexisErrant
Copy link
Contributor

Fixed version of #231 after restarting my entire dfhack fork.

exportlegends how takes an argument to export everything (all) or just the detailed maps (maps).

log-region was giving error messages, so I've added a check that only calls the script on loading a fort, not legends or adventurer - which it couldn't handle.

Added scripts `exportlegends` and `log-region`, including init and
readme entries.  The init file now has a section for legends-mode
keybindings.
@angavrilov
Copy link
Member

Your scripts still use tabs, and moreover at the stupid setting of 4 spaces per tab. That looks awful in anything that uses the proper settings of 8 characters, like even the github file viewer.

@PeridexisErrant
Copy link
Contributor Author

Sorry - I've only really learnt some Python and was taught that way.

I assume that replacing tabs with eight spaces would fix this? And is there a DFHack style guide somewhere that can avoid this kind of issue in the future?

apparently an important style thing, which I missed
@lethosor
Copy link
Member

https://github.com/DFHack/dfhack/blob/master/Compile.rst#contributing-to-dfhack
What angavrilov means is that your editor displays tabs as four spaces, but many other tools (including Github) display them as 8, resulting in things like this.
Edit: Most DFHack scripts use 4 spaces as well (not just plugins), so I'd go with that.

@PeridexisErrant
Copy link
Contributor Author

Right, thanks. One moment while I replace all the new eight-space indentations with four...

Edit: done.

should have read the documentation before trying a style fix...
@angavrilov angavrilov merged commit 01d302e into DFHack:develop May 12, 2014
@PeridexisErrant PeridexisErrant deleted the add-exportlegends-and-logregion branch May 15, 2014 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants