add three scripts #231
Closed
add three scripts #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `exportmaps` and `log-region`, having fixed a typo and added attribution as a second-line comment. First (broken) attempt at `exportlegends`. `log-region` returns a nil value (for 'site') if a world is loaded in adventure or legends mode.
adds readme info for `log-region` and `exportmaps`, which work. `exportlegends` is broken and thus undocumented.
stuck in an extra test that `site ~= nil` before writing; which catches the error and also confines the script to fort mode - fortunate since the output only make sense for fort mode.
Instead of trying to add stuff to the cycle, I just stuck two pairs of lines in before the cycle starts.
Kurik Amudnil's script `exportmaps` with minor spelling fixes; `log-region` with an extra test to catch the nil value error and only run in fort mode. New script exportlegends (closely related) which exports the map/gen info, xml, and all detailed maps.
…//github.com/PeridexisErrant/dfhack into PeridexisErrant/log-region-and-exportlegends
includes new legends-mode section of the init file
|
The two export scripts are so similar that they should be one script with an argument. The dfhack.init entry is also a complete duplicate. |
|
I'll fix and send a new request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kurik Amudnil's script
exportmapswith minor spelling fixes;log-regionwith an extra test to catch the nil value error and onlyrun in fort mode. New script
exportlegends(closely related) whichexports the map/gen info, xml, and all detailed maps.