Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Changes tf message type to tf2. #58

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

matthias-mayr
Copy link
Contributor

We noticed that the MIR is publishing messages in tf2. This is one way that works from us, but one might want to use one of those rewrite functions.

I am not too familiar with this software stack, so I leave it to you.

@mintar
Copy link
Member

mintar commented Jul 1, 2020

This is only a cosmetic change. tf.msg.tfMessage and tf2_msgs.msg.TFMessage have the same md5sum, so it doesn't matter which one you publish; if one node publishes tf and another subscibes to tf2, it just works.

I have no objections against switching to tf2, but in that case also the package.xml and tf_remove_child_frames.py should be updated. If you want to add it to this PR, I'll merge it.

Some transformations are published on this topic and are needed to
obtain a full tf tree. E.g. "base_footprint" to "base_link"
@matthias-mayr
Copy link
Contributor Author

Thanks for the comments. They were exactly the type of comment I wanted to have on this PR.

I removed the change of the tf message include and added only the additional subscription that is necessary to get a full tf tree.

@mintar
Copy link
Member

mintar commented Jul 8, 2020

Ah, I hadn't seen that part of the PR. Yes, adding tf_static is of course necessary. Thanks for the fix!

@mintar mintar merged commit 4abbecd into DFKI-NI:melodic-2.8 Jul 8, 2020
@matthias-mayr matthias-mayr deleted the pr_tf2 branch July 8, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants