added option for quantile regression in scatter #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via bool fit_to_quantiles parameter
ecomodeller
requested changes
May 24, 2023
fmskill/plot.py
Outdated
| ) | ||
|
|
||
| if fit_to_quantiles: | ||
| plt.plot( |
There was a problem hiding this comment.
Try to reduce duplication, e.g. by creating new variables that for the x,ys that will be used in the regression.
Right now, in order to understand the code, you have to compare the two branches of the condition, and try to spot the differences, it is better if it is obvious.
There was a problem hiding this comment.
Good catch, thanks! I made it more concise
overwriting x_trend for conciseness. Might be dangerous be we don't use it anywhere else.
ecomodeller
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via bool fit_to_quantiles parameter