Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aesthetics of skill table and scatter plot #212

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

stkistner
Copy link
Collaborator

Aesthetic updates to modelskill plots:

  • Skill table now uses normal font. Can do with some refactoring, but it works :)
  • Unless specified, scatter defaults to PowerNorm
  • Added plot.rcParams as a registered setting/style. This should help with font styles associated with style groups, e.g. removing the italics in mathtext. At the moment is not auto-initialized, thus requiring the following line of code:
    plt.rcParams.update(modelskill.settings.get_option('plot.rcParams'))

@daniel-caichac-DHI
Copy link
Collaborator

daniel-caichac-DHI commented Jun 21, 2023

Hi. Good work. Could you upload a before/after screenshot of how the scatter plot changes? (scatter plot as is now vs scatter plot from the PR)
With the mood style on please :). I saw some examples on the notebooks you updated but if this is doing what I think is doing maybe the gamma=0.5 is too transparent? the picture will help me visualize the changes.

modelskill/plot.py Outdated Show resolved Hide resolved
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - agree with @daniel-caichac-DHI that it would be great to see examples :-) See also comments

modelskill/plot.py Show resolved Hide resolved
modelskill/plot.py Outdated Show resolved Hide resolved
@jsmariegaard
Copy link
Member

Actually, one more thing I forgot: is it possible to only have int values on the colorbar? And maybe you could re-run the notebook to remove the print statement ...

image

@stkistner
Copy link
Collaborator Author

Hi. Good work. Could you upload a before/after screenshot of how the scatter plot changes? (scatter plot as is now vs scatter plot from the PR) With the mood style on please :). I saw some examples on the notebooks you updated but if this is doing what I think is doing maybe the gamma=0.5 is too transparent? the picture will help me visualize the changes.

Screenshots below. The gamma=0.5 is the steepness of the PowerNorm function, i.e. $f(x)=x^\gamma$. The transparency you see here is unchanged.

Before
image

After
image

@daniel-caichac-DHI
Copy link
Collaborator

Jesper already approved so you could merge by clicking
image
but it would be nice to see a picture when you activate style='MOOD', that everything still works, as in, nothing got corrupted :)

@stkistner
Copy link
Collaborator Author

Jesper already approved so you could merge by clicking ... but it would be nice to see a picture when you activate style='MOOD', that everything still works, as in, nothing got corrupted :)

I know... just making some minor changes as requested 🙂

image

Another commit coming in soon

@stkistner stkistner merged commit ec986dc into main Jun 21, 2023
@stkistner stkistner deleted the skill_table_r1 branch June 21, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants