Extract ComparerPlotter from Comparer & Comparison module in subfolder #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecomodeller
changed the title
|
Tests are somewhat a mixed bag, with some tests changed to make use of |
jsmariegaard
approved these changes
Jun 27, 2023
modelskill/comparison/_comparison.py
Outdated
| title=None, | ||
| xlabel=None, | ||
| ylabel=None, | ||
| binsize=None, |
There was a problem hiding this comment.
These three arguments are not used. Delete?
There was a problem hiding this comment.
The three I refer to are:
binsize=None,
nbins=None,
skill_table=None,
There was a problem hiding this comment.
I just now see that the same goes for hist() below - maybe **kwargs it all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotting function extracted to separate file(s) and existing ones have been deprecated.