Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skill_table also for plotting.scatter #369

Merged
merged 6 commits into from
Jan 2, 2024
Merged

skill_table also for plotting.scatter #369

merged 6 commits into from
Jan 2, 2024

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Jan 2, 2024 •
edited
Loading

image

jsmariegaard
jsmariegaard approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I added the possibility to give a list of metrics as skill_table. For consistency with other scatter methods.

@jsmariegaard
Copy link
Member

@ecomodeller , are you okay with my edits? Can we merge?

@jsmariegaard jsmariegaard merged commit cd23304 into main Jan 2, 2024
10 checks passed
@jsmariegaard jsmariegaard deleted the scatter branch January 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmariegaard jsmariegaard jsmariegaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @jsmariegaard