Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Appendix example IDs. #46

Merged
merged 2 commits into from
Jun 9, 2020
Merged

FIX: Appendix example IDs. #46

merged 2 commits into from
Jun 9, 2020

Conversation

carlwilson
Copy link
Collaborator

No description provided.

@carlwilson carlwilson self-assigned this Jun 9, 2020
@carlwilson carlwilson added the bug label Jun 9, 2020
@carlwilson carlwilson added this to the DIP v2.0.4 milestone Jun 9, 2020
@@ -243,7 +243,7 @@
</mets:metsHdr>
</Example>
<Example ID="dmdSecExample1" LABEL="METS example of referencing the descriptive metadata which is described with an EAD document">
<mets:dmdSec ID="uuid-906F4F12-BA52-4779-AE2C-178F9206111F" CREATED="2018-04-24T14:37:49.609+01:00" STATUS="CURRENT">
<mets:dmdSec ID="dmdExmpl.file.siard" CREATED="2018-04-24T14:37:49.609+01:00" STATUS="CURRENT">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be linked to the EAD and not siard?

LABEL="Metadata"
ADMID="uuid-9124DA4D-3736-4F69-8355-EB79A22E943F uuid-48C18DD8-2561-4315-AC39-F941CBB138B3"
DMDID="uuid-906F4F12-BA52-4779-AE2C-178F9206111F"/>
ADMID="appdx1.digiprov-premis-file-1 appdx1.digiprov-premis-file-2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "appndx1.digiprov.premis2 appndx1.digiprov.premis"

ADMID="uuid-9124DA4D-3736-4F69-8355-EB79A22E943F uuid-48C18DD8-2561-4315-AC39-F941CBB138B3"
DMDID="uuid-906F4F12-BA52-4779-AE2C-178F9206111F"/>
ADMID="appdx1.digiprov-premis-file-1 appdx1.digiprov-premis-file-2"
DMDID="dmdSecExample1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "appndx1.dmd.ead"

CONTENTIDS="uuid-4ACDC6F3-8A36-4A00-A85F-84A56415E86H"/>
ID="appdx1.div.doc"
LABEL="Documentation">
<mets:fptr FILEID="appdx1.filegrp-doc"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "appndx1.filegrp.doc"

CONTENTIDS="uuid-4ACDC6F3-8A36-4A00-A85F-84A56415E86F"/>
ID="appdx1.div.schm"
LABEL="Schemas">
<mets:fptr FILEID="appdx1.filegrp-schema"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "appndx1.filegrp.schm"

CONTENTIDS="uuid-4ACDC6F3-8A36-4A00-A85F-84A56415E86G" />
ID="appdx1.div.reps"
LABEL="Representations">
<mets:fptr FILEID="appdx1.filegrp.data"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "appndx1.filegrp.reps"

Copy link
Contributor

@karinbredenberg karinbredenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@carlwilson carlwilson merged commit f763c86 into rel/2.0 Jun 9, 2020
@carlwilson carlwilson deleted the fix/appendix-ids branch June 9, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants