Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitre-attack references hardcoded in STIX generation logic #5

Open
himynamesdave opened this issue Aug 23, 2023 · 1 comment
Open

Comments

@himynamesdave
Copy link

It appears a lot of the code for object has been copied from ATT&CK repo (which is fine). However, it seems some hardcoded values have been incorrectly copied across, in kill_chain_phases and external_references, e.g.

           "kill_chain_phases": [
                {
                    "kill_chain_name": "mitre-attack",
                    "phase_name": "drive-online-harms"
                }
            ],
            "external_references": [
                {
                    "source_name": "mitre-attack",
                    "url": "https://github.com/DISARMFoundation/DISARM_framework/blob/master/techniques/T0048.004.md",
                    "external_id": "T0048.004"
                }
            ],

Suggestion to replace hardcoded mitre-attack with DISARM

@himynamesdave
Copy link
Author

Can confirm, does not affect ATT&CK Navigator support

https://raw.githubusercontent.com/signalscorps/DISARM-STIX2/main/output/DISARM.json

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant