Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-fno-gnu-unique flag should be set not based on OS but based on compiler, and clang doesn't know about it #237

Closed
yurivict opened this issue May 21, 2022 · 1 comment

Comments

@yurivict
Copy link

yurivict commented May 21, 2022

clang fails because of this flag.

Many places in code set this flag for non-MacOS and non-Windows. This is wrong - it should be based on compiler.

clang-12 on FreeBSD 13

@falkTX
Copy link
Contributor

falkTX commented May 28, 2022

Detecting this is not as easy as it might seem.. clang likes to pretend and be gcc compatible, at least on linux.
Since I know you mostly just want this for compatibility with BSD, I made it so that in cardinal, carla and dpf, -fno-gnu-unique is skipped if using bsd.
That should fix things for your side.
Let me know if not the case, I will then reopen the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants