-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I install the Mini variants? #528
Comments
Indeed, I forgot to add it in https://github.com/DISTRHO/Cardinal/blob/main/Makefile#L272 Since you are packaging and testing this, a patch-fix would be appreciated. |
You want me to do a PR? I can copy and modify the lines that install the plugins, but I don't understand the |
The I can fix this myself for 23.04 in case you have troubles coming up with a patch-fix. |
What do you mean by patch-fix, if not a PR? |
an actual patch file? it doesnt have to be a PR, good patch or just inline diff in the comments works too. |
OK, PR coming up, but it'll take while... |
Untested, I'm still cloning, but IIUC, all I need is the standalone and the lv2, there is no mini clap or vst, right? @@ -274,6 +274,7 @@ install:
install -d $(DESTDIR)$(PREFIX)/lib/lv2/Cardinal.lv2
install -d $(DESTDIR)$(PREFIX)/lib/lv2/CardinalFX.lv2
install -d $(DESTDIR)$(PREFIX)/lib/lv2/CardinalSynth.lv2
+ install -d $(DESTDIR)$(PREFIX)/lib/lv2/CardinalMini.lv2
install -d $(DESTDIR)$(PREFIX)/lib/clap/Cardinal.clap
install -d $(DESTDIR)$(PREFIX)/lib/vst/Cardinal.vst
ifeq ($(VST3_SUPPORTED),true)
@@ -287,6 +288,7 @@ endif
install -m 644 bin/Cardinal.lv2/*.* $(DESTDIR)$(PREFIX)/lib/lv2/Cardinal.lv2/
install -m 644 bin/CardinalFX.lv2/*.* $(DESTDIR)$(PREFIX)/lib/lv2/CardinalFX.lv2/
install -m 644 bin/CardinalSynth.lv2/*.* $(DESTDIR)$(PREFIX)/lib/lv2/CardinalSynth.lv2/
+ install -m 644 bin/CardinalMini.lv2/*.* $(DESTDIR)$(PREFIX)/lib/lv2/CardinalMini.lv2/
install -m 644 bin/Cardinal.clap/*.* $(DESTDIR)$(PREFIX)/lib/clap/Cardinal.clap/
install -m 644 bin/Cardinal.vst/*.* $(DESTDIR)$(PREFIX)/lib/vst/Cardinal.vst/
@@ -298,6 +300,7 @@ ifeq ($(VST3_SUPPORTED),true)
endif
install -m 755 bin/Cardinal$(APP_EXT) $(DESTDIR)$(PREFIX)/bin/
+ install -m 755 bin/CardinalMini$(APP_EXT) $(DESTDIR)$(PREFIX)/bin/
install -m 755 bin/CardinalNative$(APP_EXT) $(DESTDIR)$(PREFIX)/bin/ |
correct. mini is just standalone and lv2 |
I'm having trouble testing.
The diff file I generated does not apply. I have committed the diff file as well, so you can see it: 23.02...magnetophon:Cardinal:wip Any ideas? |
|
Thanks! |
They get built, but not installed, as far as I can tell.
Do I need to do anything different?
I've looked at the makefile, but I don't see where
APP_EXT
gets defined.Here's the relevant part of the output: https://gist.github.com/magnetophon/c33baec34794e428071bf20fe94e0099
The text was updated successfully, but these errors were encountered: