Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display settings revert themselves after closing #534

Closed
pastarat opened this issue Apr 30, 2023 · 9 comments
Closed

Display settings revert themselves after closing #534

pastarat opened this issue Apr 30, 2023 · 9 comments

Comments

@pastarat
Copy link

cardinalbug
When I enable light mode or change the cable tension, these settings automatically reset after closing FL Studio (v21.0.3)

I tried changing the settings and then saving a project. That still resets the color mode, but not the cable tension.

Affected Cardinal versions: 64-bit Windows VST3 23.02, 5307b9f

@dromer
Copy link
Collaborator

dromer commented Apr 30, 2023

Hmm, would indeed expect all of this state to be saved with the project. For me this has been the case so far (but I never switch light-mode so maybe that's why I never noticed).

@jn64
Copy link
Contributor

jn64 commented Jul 2, 2023

In my test, all the other appearance settings (zoom, cable opacity etc) were saved, but light mode was not (it reverts to dark mode).

Cardinal LV2 23.02
Host: Carla 2.5.5
OS: Fedora 38

@falkTX
Copy link
Contributor

falkTX commented Jul 2, 2023

this is fixed in latest git and will be part of the next release in 13 days

@pastarat
Copy link
Author

This issue is still present in version 23.07

@falkTX
Copy link
Contributor

falkTX commented Jul 15, 2023

I cannot confirm, at least on standalone it behaves as expected.

when closing cardinal you should see a line like this:

[3.813 info Rack/src/settings.cpp:491 save] Saving settings /home/falktx/.config/Cardinal/main.json

and that file will have theme mode inside it, like so:

"uiTheme": "light",

When the ui theme is "light", it will make the dark mode off when starting up a new instance.

@jn64
Copy link
Contributor

jn64 commented Jul 16, 2023

I also cannot confirm. It is fixed for me in 23.07. I tested standalone normal and Mini, and lv2 normal and Mini in Carla host on Linux.

@pastarat
Copy link
Author

I meant to say it's the 64-bit VST3 version (in FL Studio 21) that won't save the settings. I tried changing the display to light mode in the standalone version, and it worked fine because the settings were stored in the native.json file.

@falkTX
Copy link
Contributor

falkTX commented Jul 16, 2023

the plugin version will save to fx.json or synth.json or main.json, depending on the variant.
could be that the settings only apply to new instances, not previously saved ones though

@falkTX
Copy link
Contributor

falkTX commented Oct 24, 2023

Fixed in 23.10 release, there was an issue saving user preferences under Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants