Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Throttle and turn angle limits #101

Closed
axe007 opened this issue May 11, 2021 · 1 comment · Fixed by #117
Closed

[BUGFIX] Throttle and turn angle limits #101

axe007 opened this issue May 11, 2021 · 1 comment · Fixed by #117
Assignees
@nikalc
Labels
bug Something isn't working JS Javascript work NodeJS NodeJS and ElectronJS related tasks sprint-3 User stories & bugs for TBD on sprint 3 sprint-4 User stories & bugs for TBD on sprint 4
Projects
SmartRover Scrum Board
Milestone
Maintain good pro...

Comments

@axe007
Copy link
Contributor

axe007 commented May 11, 2021

Describe the bug
When manually controlling the rover from Manual control page using either Control pad or terminal console, throttle and turn angle values are not limited within operating range.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Manual Control page
  2. Click on Power and Satellite, and then control the rover as usual.
  3. If you keep pressing forward button, throttle percentage exceeds 100 and goes on.
  4. See "error" on Telemetry dashboard.

Expected behavior

  • The throttle application operating range is from -100 to 100. Forward up to 100, and reverse down to -100.
  • Turn angle is from -180 to 180. Turning left is negative 180 degrees and going right is positive 180 degrees.

Tasks

  • Need to add throttle and turn angle value check within manualControl() function.
  • Update terminal console RegEx pattern check to limit options.
  • Proper message needs to be displayed when maximum or minimum value had reached.
@axe007 axe007 added bug Something isn't working sprint-3 User stories & bugs for TBD on sprint 3 JS Javascript work NodeJS NodeJS and ElectronJS related tasks labels May 11, 2021
@axe007 axe007 added this to Backlog in SmartRover Scrum Board via automation May 11, 2021
@axe007 axe007 moved this from Backlog to In progress in SmartRover Scrum Board May 11, 2021
@axe007
Copy link
Contributor Author

axe007 commented May 15, 2021

Push back into Sprint 4

@axe007 axe007 added the sprint-4 User stories & bugs for TBD on sprint 4 label May 15, 2021
axe007 added a commit that referenced this issue May 24, 2021
@axe007
Implement bugfixes
ed6453f 
Completed:
- Fixed a bug for throttle going beyond 100
- Fixed a bug for turn angle going beyond 180
- Homepage style fix
- User menu accessible from all pages
- System toast notification close svg missing
- User profile timeout after 12 hours
- Database connection start and termination fix
- Settings page opening tab fix
- Settings and Help style update for tabs
- Update Readme.md with more recent information

Resolves #101
@axe007 axe007 mentioned this issue May 24, 2021
Merged
@axe007 axe007 moved this from In progress to Review in SmartRover Scrum Board May 24, 2021
SmartRover Scrum Board automation moved this from Review to Done May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikalc nikalc

Labels
bug Something isn't working JS Javascript work NodeJS NodeJS and ElectronJS related tasks sprint-3 User stories & bugs for TBD on sprint 3 sprint-4 User stories & bugs for TBD on sprint 4
Projects
SmartRover Scrum Board
Done
Milestone
Maintain good project management
Development

Successfully merging a pull request may close this issue.

Implement bugfixes DIT112-V21/group-09
2 participants
@axe007 @nikalc