Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #865 #866

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix #865 #866

merged 1 commit into from
Dec 14, 2021

Conversation

joergbrech
Copy link
Contributor

fix #865

Description

This PR changes the tolerances used in the calls to CCPACSWingCell::CutChordWise and CCPACSWIngCell::CutSpanWise. These tolerances are used to check, wether a wing cell border lies on an isosurface of a single face (within the bounds defined by said tolerance). If yes, TiGL will trim the face to create the cell geometry. If no, TiGL will cut the face using expensive Boolean operations.

The consequence of a stricter tolerance is only that in more cases the Boolean operations will be used, increasing the calculation time and accuracy.

How Has This Been Tested?

I wouldn't know how to define a unit test of this. This has been tested with an internal CPACS file where the inaccuracies were evident in TiGLViewer.

Screenshots, that help to understand the changes(if applicable):

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

@codecov-commenter
Copy link

Codecov Report

Merging #866 (d1b5a0e) into master (a1af6b2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   62.54%   62.54%           
=======================================
  Files         292      292           
  Lines       24636    24636           
=======================================
  Hits        15408    15408           
  Misses       9228     9228           
Impacted Files Coverage Δ
src/engine_nacelle/CCPACSEnginePosition.h 50.00% <ø> (ø)
src/wing/CCPACSWingCell.cpp 21.44% <0.00%> (ø)

@rainman110 rainman110 merged commit e3a80e5 into master Dec 14, 2021
@rainman110 rainman110 deleted the 865-wingcell-tolerances branch December 14, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccuracies when defining a wing cell border using ribs and spars
3 participants