Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #865
Description
This PR changes the tolerances used in the calls to
CCPACSWingCell::CutChordWise
andCCPACSWIngCell::CutSpanWise
. These tolerances are used to check, wether a wing cell border lies on an isosurface of a single face (within the bounds defined by said tolerance). If yes, TiGL will trim the face to create the cell geometry. If no, TiGL will cut the face using expensive Boolean operations.The consequence of a stricter tolerance is only that in more cases the Boolean operations will be used, increasing the calculation time and accuracy.
How Has This Been Tested?
I wouldn't know how to define a unit test of this. This has been tested with an internal CPACS file where the inaccuracies were evident in TiGLViewer.
Screenshots, that help to understand the changes(if applicable):
Checklist: