Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Frontend Share Output. Add Custom Click to Share Option to Block. #75

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Fix Frontend Share Output. Add Custom Click to Share Option to Block. #75

merged 2 commits into from
Mar 26, 2023

Conversation

ronalfy
Copy link
Collaborator

@ronalfy ronalfy commented Mar 26, 2023

Description

The PR fixes one bug and adds one new feature.

  1. Fixes the frontend output of the Click to Share block.
  2. Adds a "Share Text Override" where a user can customize what is shared out.

Fixes #70

Type of PR

  • Bug fix
  • Feature
  • Security fix
  • Other (please describe)

Where is the Bug? (please remove if not relevant)

  • Click to Share Block
  • Admin settings
  • Inline highlighting
  • Highlighting Text
  • Social Sharing

How Has This Been Tested (please remove if not relevant)?

Select any that are applicable

  • Browser tests
  • Performance tests
  • Local testing

Checklist

Please select all that are applicable.

  • I have set development as the base branch.
  • I have added appropriate labels to the PR.
  • I have referenced the base issue to address.
  • I have secured the code by sanitizing and escaping all inputs and outputs
  • I have cached any expensive queries
  • I have added any screenshots or videos related to the PR.

@ronalfy ronalfy self-assigned this Mar 26, 2023
@ronalfy ronalfy merged commit d38db29 into development Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ronalfy ronalfy

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request - Have Custom Share Text Option in Click to Share Block
2 participants
@ronalfy @ronaldhuereca