Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Unclosed tags #83

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

harrinsonmb
Copy link
Contributor

Description

There were some HTML tags that were not closed, that were causing problems in the printed DOM.

Type of PR

  • Bug fix
  • Feature
  • Security fix
  • Other (please describe)

Where is the Bug? (please remove if not relevant)

  • Click to Share Block
  • Admin settings
  • Inline highlighting
  • Highlighting Text
  • Social Sharing

How Has This Been Tested (please remove if not relevant)?

Select any that are applicable

  • Browser tests
  • Performance tests
  • Local testing

Checklist

Please select all that are applicable.

  • I have set development as the base branch.
  • I have added appropriate labels to the PR.
  • I have referenced the base issue to address.
  • I have secured the code by sanitizing and escaping all inputs and outputs
  • I have cached any expensive queries
  • I have added any screenshots or videos related to the PR.

There were some HTML tags that were not closed, and it was causing problems in the final DOM.
@harrinsonmb harrinsonmb changed the title Unclosed tags Bugfix: Unclosed tags May 15, 2023
Copy link
Collaborator

@ronalfy ronalfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good.

@ronalfy ronalfy merged commit 77ba7ec into DLXPlugins:development May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants