Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localnet vs remotenet as config param ? #97

Open
SurfingNerd opened this issue Mar 27, 2024 · 0 comments
Open

localnet vs remotenet as config param ? #97

SurfingNerd opened this issue Mar 27, 2024 · 0 comments

Comments

@SurfingNerd
Copy link
Collaborator

SurfingNerd commented Mar 27, 2024

currently the config does not tell if a network is a local net or a remote net.
especially, a localnet can be deployed to become a remotenet.
in this case the localnet should not be used anymore.

the project structure defines 3 set of functions concerning networks::

  • localnet-xyz : interacts with local processes and local files - function can not be applied on a remotenet.
  • remotenet-xyz : interacts via SSH with remote nodes - functions can not be applied on a localnet
  • net-xyz: interacts with RPC only, functions can be applied to localnet and remotenets.

there is also testnet-xyz what means localnet in it's essence, but usually refers to integration tests for a specific feature.
this testnet naming pattern should be reworked, by either specifying features and restrictions that only apply to integration tests, or completly replaced with localnet.

Tests that are currently written for net suffer the inability to not spin up and shut down the 'localnet' - and are currently not suitable for automatic integration tests - that issue should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant