Prefix all constants with DMOJ_ #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyene
reviewed
Mar 29, 2019
judge/models/profile.py
Outdated
| .annotate(max_points=Max('submission__points')).order_by('-max_points') | ||
| .values_list('max_points', flat=True).filter(max_points__gt=0)) | ||
| extradata = Problem.objects.filter(submission__user=self, submission__result='AC', is_public=True).values('id') | ||
| .distinct().count() |
quantum5
requested changes
Mar 29, 2019
| table = (lambda x: [pow(x, i) for i in xrange(100)])(getattr(settings, 'PP_STEP', 0.95)) | ||
| bonus_function = getattr(settings, 'PP_BONUS_FUNCTION', lambda n: 300 * (1 - 0.997 ** n)) | ||
| _pp_step = getattr(settings, 'DMOJ_PP_STEP', 0.95) | ||
| table = (lambda x: [pow(x, i) for i in xrange(getattr(settings, 'DMOJ_PP_ENTRIES', 100))])(_pp_step) |
There was a problem hiding this comment.
Why do we still need this lambda? It only existed in the old code because whoever wrote it does not want to have a variable.
| for row in Profile.objects.all(): | ||
| data = (Problem.objects.filter(submission__user=row, submission__points__isnull=False, is_public=True) | ||
| .annotate(max_points=Max('submission__points')).order_by('-max_points') | ||
| .values_list('max_points', flat=True)) | ||
| extradata = Problem.objects.filter(submission__user=row, submission__result='AC', is_public=True).values('id').distinct().count() | ||
| extradata = Problem.objects.filter(submission__user=row, submission__result='AC', is_public=True).values('id') | ||
| .distinct().count() |
judge/models/profile.py
Outdated
| .annotate(max_points=Max('submission__points')).order_by('-max_points') | ||
| .values_list('max_points', flat=True).filter(max_points__gt=0)) | ||
| extradata = Problem.objects.filter(submission__user=self, submission__result='AC', is_public=True).values('id') | ||
| .distinct().count() |
|
Also provide a list of changes, and preferably, a |
|
This doesn't look broken, but given that past changes have syntax errors, I would like to see this code being run. |
|
Still need a |
quantum5
requested changes
Apr 2, 2019
judge/models/profile.py
Outdated
| extradata = Problem.objects.filter(submission__user=self, submission__result='AC', is_public=True).values('id').distinct().count() | ||
| bonus_function = getattr(settings, 'PP_BONUS_FUNCTION', lambda n: 300 * (1 - 0.997 ** n)) | ||
| data = (Problem.objects.filter(submission__user=self, submission__points__isnull=False, is_public=True, | ||
| is_organization_private=False) \ |
There was a problem hiding this comment.
Why are you using \ when between ( and )?
quantum5
approved these changes
Apr 2, 2019
kiritofeng
added a commit
that referenced
this pull request
Apr 3, 2019
quantum5
pushed a commit
that referenced
this pull request
Apr 3, 2019
Ninjaclasher
pushed a commit
to mcpt/wlmoj
that referenced
this pull request
Apr 3, 2019
Ninjaclasher
pushed a commit
to mcpt/wlmoj
that referenced
this pull request
Apr 3, 2019
Ninjaclasher
pushed a commit
to mcpt/wlmoj
that referenced
this pull request
Apr 14, 2019
gozzarda
added a commit
to uwapcs/pcs-org-au-dmoj
that referenced
this pull request
Aug 27, 2019
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
Changed constants to follow new naming convention for constants, `DMOJ_MODULE_<NAME>`, as decided in Slack.
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New naming convention for constants is
DMOJ_MODULE_<NAME>, as decided in Slack.