Refactor CSS/JS for Download Plan page #561
Comments
briri
added a commit
to CDLUC3/dmptool
that referenced
this issue
Sep 8, 2017
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format
briri
added a commit
to CDLUC3/dmptool
that referenced
this issue
Sep 12, 2017
* DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download.
briri
added a commit
to CDLUC3/dmptool
that referenced
this issue
Sep 12, 2017
- Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js
briri
added a commit
to CDLUC3/dmptool
that referenced
this issue
Sep 12, 2017
* DMPRoadmap/roadmap#issue567 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. * Boostrapped the create plan page. DMPRoadmap#632 - Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js * Boostrapped the create plan page
briri
pushed a commit
that referenced
this issue
Sep 15, 2017
* adding bootstrap classes to the form * add bootstrap classes to user details and preferences tab * add user profile page js file * add other tabs form to js bundle as well * import password validator js into user_profile * Pulling in Bootstrap of Create Plan changes (#89) * DMPRoadmap/roadmap#issue567 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion #567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions #567 finished Bootstrapping write plan accordions #567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page #561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * #562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. * Boostrapped the create plan page. #632 - Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion #567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions #567 finished Bootstrapping write plan accordions #567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page #561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * #562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js * Boostrapped the create plan page * add user profile page js file * add other tabs form to js bundle as well import password validator js into user_profile update the jquery to es6 for preferences * fixing minor issues on user_profile related to forms
briri
added a commit
to CDLUC3/dmptool
that referenced
this issue
Sep 15, 2017
* DMPRoadmap/roadmap#issue567 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. * Boostrapped the create plan page. DMPRoadmap#632 - Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js * Boostrapped the create plan page * Bootstrap User profile page (#563) (#637) * adding bootstrap classes to the form * add bootstrap classes to user details and preferences tab * add user profile page js file * add other tabs form to js bundle as well * import password validator js into user_profile * Pulling in Bootstrap of Create Plan changes (#89) * DMPRoadmap/roadmap#issue567 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. * Boostrapped the create plan page. DMPRoadmap#632 - Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page DMPRoadmap#561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * DMPRoadmap#562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js * Boostrapped the create plan page * add user profile page js file * add other tabs form to js bundle as well import password validator js into user_profile update the jquery to es6 for preferences * fixing minor issues on user_profile related to forms
|
visual inspection on stage. closing issue. |
johnpinto1
pushed a commit
to DigitalCurationCentre/roadmap
that referenced
this issue
Jul 8, 2021
… a managed Org. Change: - On save or update of an Org that is managed we add all the token_permission_types for API access using a before_save callback.
johnpinto1
pushed a commit
that referenced
this issue
Aug 24, 2021
return the standard html error page.
Changes:
In ApplicationController:
- so that rescue_from errors are rendered appropriately formatted messages for html
and json with a private method render_respond_to_format_with_error_message()
- added a rescue_from StandardError with a method handle_server_method()
- updated existing user_not_authorized
- updated rescue_from ActiveRecord::RecordNotFound by removing if Production condition
- added missing method render_not_found()
In spec/controllers/super_admin/orgs_controller_spec.rb failing tests
(1) merge_analyze: test "fails if user is not a super admin"
(2) merge_commit: test "fails if user is not a super admin"
- changed redirect_to(plans_path) -> redirect_to(root_path)
- removed "format: :js" because of ActionController::UnknownFormatError
post :merge_analyze, params: @params. format: :js
and
post :merge_commit, params: @params. format: :js
briri
added a commit
that referenced
this issue
Aug 24, 2021
…urn_json_not_html_page Issue #561 - Fix for ensuring Json format rendering errors no longer
portagenetwork
referenced
this issue
in portagenetwork/roadmap
Feb 24, 2022
Org. Change: - On save or update of an Org that is managed we add all the token_permission_types for API access using a before_save callback.
portagenetwork
referenced
this issue
in portagenetwork/roadmap
Feb 24, 2022
return the standard html error page.
Changes:
In ApplicationController:
- so that rescue_from errors are rendered appropriately formatted messages for html
and json with a private method render_respond_to_format_with_error_message()
- added a rescue_from StandardError with a method handle_server_method()
- updated existing user_not_authorized
- updated rescue_from ActiveRecord::RecordNotFound by removing if Production condition
- added missing method render_not_found()
In spec/controllers/super_admin/orgs_controller_spec.rb failing tests
(1) merge_analyze: test "fails if user is not a super admin"
(2) merge_commit: test "fails if user is not a super admin"
- changed redirect_to(plans_path) -> redirect_to(root_path)
- removed "format: :js" because of ActionController::UnknownFormatError
post :merge_analyze, params: @params. format: :js
and
post :merge_commit, params: @params. format: :js
portagenetwork
referenced
this issue
in portagenetwork/roadmap
Feb 24, 2022
…should_return_json_not_html_page Issue #561 - Fix for ensuring Json format rendering errors no longer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refer to the work done in #555 for tabs and #554 for forms
The text was updated successfully, but these errors were encountered: