Bootstrapped Edit Profile page #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion #567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions #567 finished Bootstrapping write plan accordions #567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue
Bootstrapped Accordions on Write Plan page
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format
edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller
Bootstrapped Plan Download
- Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion #567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions #567 finished Bootstrapping write plan accordions #567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page #561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * #562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js
Boostrapped the Create Plan page
* adding bootstrap classes to the form * add bootstrap classes to user details and preferences tab * add user profile page js file * add other tabs form to js bundle as well * import password validator js into user_profile * Pulling in Bootstrap of Create Plan changes (#89) * DMPRoadmap/roadmap#issue567 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion #567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions #567 finished Bootstrapping write plan accordions #567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page #561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * #562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. * Boostrapped the create plan page. #632 - Converted JS for page over to ES6 - Added stub test and fixture - Converted jquery autocomplete combobox to Bootstrap and ES6 TODO: - Add in AJAX calls to retrieve template options based on org/funder selections - Fix issue with the hidden id field being updated when combobox item is selected - Finish tests for the autoComplete.js Bootstrapped Plan Writing and Download pages (#88) * DMPRoadmap/roadmap#issue567 * DMPRoadmap/roadmap#issue561 - Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion #567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions #567 finished Bootstrapping write plan accordions #567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue * Bootstrapping and ES6 of the Plan Download page #561. - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format * #562 edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller * fixed linter issue with CRLF * fixed tests broken by name change from show_export to download. added JS tests for expandCollapseAll accordion functionality fixed linter complaint about double vs single quotes in test removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js * Boostrapped the create plan page * add user profile page js file * add other tabs form to js bundle as well import password validator js into user_profile update the jquery to es6 for preferences * fixing minor issues on user_profile related to forms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.