Commits on Aug 24, 2021

1. Issue #561 - Fix for ensuring Json format rendering errors no longer …

   return the standard html error page.
   
   Changes:
    In ApplicationController:
      - so that rescue_from errors are rendered appropriately formatted messages for html
        and json with a private method render_respond_to_format_with_error_message()
      - added a rescue_from StandardError with a method handle_server_method()
      - updated existing user_not_authorized
      - updated rescue_from ActiveRecord::RecordNotFound by removing if Production condition
      - added missing method render_not_found()
     In spec/controllers/super_admin/orgs_controller_spec.rb failing tests
      (1) merge_analyze: test "fails if user is not a super admin"
      (2) merge_commit: test "fails if user is not a super admin"
      - changed redirect_to(plans_path) -> redirect_to(root_path)
      - removed "format: :js" because of ActionController::UnknownFormatError
          post :merge_analyze, params: @params. format: :js
          and
          post :merge_commit, params: @params. format: :js

   John Pinto committed Aug 24, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for e770d28
   • Browse repository at this point

   Copy the full SHA

   e770d28 View commit details

   Browse the repository at this point in the history